Skip to content

Demo top toolbar polish: chat-select swaps, monochrome buttons, token cleanup#438

Merged
blove merged 8 commits into
mainfrom
claude/demo-toolbar-polish
May 18, 2026
Merged

Demo top toolbar polish: chat-select swaps, monochrome buttons, token cleanup#438
blove merged 8 commits into
mainfrom
claude/demo-toolbar-polish

Conversation

@blove
Copy link
Copy Markdown
Contributor

@blove blove commented May 18, 2026

Summary

  • Four native `` (Model, Effort, Gen UI, Theme) replaced with `` — same primitive as the chat-input model picker. Toolbar shell normalized to chat tokens: `font-family: inherit`, `font-size: var(--ngaf-chat-font-size-sm)` (14px), `border-bottom: var(--ngaf-chat-separator)`. Fallback color literals dropped. "New conversation" button restyled as a solid `--ngaf-chat-surface-alt` pill (8px radius, no border) — secondary tier matching the New project button in the sidenav. Keeps New chat as the singular text-color CTA. Demo-only changes; no library code touched, no @Ngaf version bump. Test plan [x] `pnpm nx test examples-chat-angular` — 20 tests pass [x] Local chrome-mcp verify: 4 chat-selects render with correct labels, menu opens, "New conversation" computes to bg rgb(44,44,44) / radius 8px / border 0, toolbar font 14px [ ] Canonical demo redeploys 🤖 Generated with Claude Code

blove and others added 6 commits May 18, 2026 12:27
Pulls the new demo-shell__toolbar into the chat library visual system:
14px sm font, 8px radii, chat-select primitive replacing the four native
selects, surface-alt secondary fill on the "New conversation" button.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cacheplane Ready Ready Preview, Comment May 18, 2026 8:29pm

Request Review

Resolved conflicts in demo-shell.component.{css,html} by taking the
polish-pass values — main only reformatted the same rules with line
breaks inside color-mix calls; polish-pass replaces those rules
entirely with the chat-token recipes.
… swap

The native <select> → chat-select swap broke three e2e files (helpers
using .selectOption() and .toHaveValue() against native selects, plus
.locator('option') for native option children). Updated helpers to drive
the chat-select trigger + .chat-select__option menu, and switched the
toolbar's chat-select menu to open downward (top: 100%+8px) since the
toolbar sits at the page top and the primitive's default upward popover
renders offscreen there. chat-input model picker keeps its upward
default.
@blove blove merged commit 6ba3424 into main May 18, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant